[
https://issues.apache.org/jira/browse/IVY-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508827
]
Xavier Hanin commented on IVY-545:
----------------------------------
I've checked in your unit test, thanks a lot for your contribution!
Some minor things:
- try to avoid _ in method names, it doesn't conform to our checkstyle rules
- we do not use a line separator before catch block:
{code}
try {
...
} catch (...) {
...
}
{code}
- our checkstyle rules do not allow empty catch block, a comment like "//
success" is enough to show the exception is expected.
Besides thes minors things the unit test is well written, thanks again!
> Unit test improvement
> ---------------------
>
> Key: IVY-545
> URL: https://issues.apache.org/jira/browse/IVY-545
> Project: Ivy
> Issue Type: Improvement
> Affects Versions: 2.0.0-alpha-1
> Environment: Development
> Reporter: Tjeerd Verhagen
> Assignee: Xavier Hanin
> Priority: Minor
> Fix For: 2.0.0-alpha-2
>
> Attachments: new_unit_test_ModuleIdTest.java
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
