Gilles Scokart wrote:
The sources I have seen seems to use the sun conventions (curly braces
on the same line than the class, function, if, for...).
I also seen in some classes the use of _ for the class fields.
Is it a coding conventions that should be followed, or is it just a
something used in some classes?
I would strongly prefer that we get rid of the _ and stick to the Sun one.
This is pretty common within the ASF and the standard by a wide margin.
Notorious exception from the top of my head being Turbine, Maven and
Apache DS which have a very annoying layout to me which affects
readability for my stupid brain.
Also the @author tag is now not used anymore across the asf code and
should be removed.
Generally speaking where possible, quality of code and javadoc should
also be improved when you have the chance (ie: when you fix something,
etc) as it will serve the project and also help it graduate since it is
something that will be looked at attentively afaik.
-- stephane