Concerning the use of the '_ : +1 to keep it. A few days ago, I was not a fan of it neither. However, after giving it a try in ivy code, I found that it rather good when it is used systematically. It makes the code slightly easier to understand (you identify more directly that a variable is a field), and more easy to write (no need to use 'this', code completion separates directly fields from other variables). Moreover, it is already used 'nearly' everywhere in the ivy code.
Concerning the @author tag : +1 to remove it. I don't feel confortable with it. It is never clear what it means. It is never clear how it should be updated. Moreover, it is redundant with the svn history. Concerning the checkstyle instrcutions: +1 to use it after a customisation (I din't look into the details yet, but it seems rather strict). -- Gilles SCOKART 2007/5/14, [EMAIL PROTECTED] <[EMAIL PROTECTED]>:
>> The sources I have seen seems to use the sun conventions >(curly braces >> on the same line than the class, function, if, for...). >> >> I also seen in some classes the use of _ for the class fields. >> >> Is it a coding conventions that should be followed, or is it just a >> something used in some classes? > >I would strongly prefer that we get rid of the _ and stick to >the Sun one. >This is pretty common within the ASF and the standard by a wide margin. > >Notorious exception from the top of my head being Turbine, Maven and >Apache DS which have a very annoying layout to me which affects >readability for my stupid brain. > >Also the @author tag is now not used anymore across the asf code and >should be removed. > >Generally speaking where possible, quality of code and javadoc should >also be improved when you have the chance (ie: when you fix something, >etc) as it will serve the project and also help it graduate >since it is >something that will be looked at attentively afaik. I added a path on https://issues.apache.org/jira/browse/IVY-483 containing Checkstyle instructions coming from Ant. The checkstyle-config must be adapted to Ivy's need. Jan
