Opps, sorry, I sent the e-mail without checking ;-) I found that when doing ant checkstyle, the two hard tasks are fixing the javadoc and removing in-line constants.
tabs, spacing, brackets are easy - i.e. they have no impact on code and involve no "front-lobe" thoughs. Peter On 5/24/07, Xavier Hanin <[EMAIL PROTECTED]> wrote:
On 5/24/07, Peter Reilly <[EMAIL PROTECTED]> wrote: > > Why not set up a checkstyle target like the > one in the ant build.? What do you mean? Maarten has just setup a checkstyle target and that's how we know the number of checkstyle errors, which is huge :) But it's only an indicator, and reducing this number takes time. Xavier Peter > > On 5/24/07, Gilles Scokart <[EMAIL PROTECTED]> wrote: > > Clearly! Nobody will complain if you reduce the numbers of errors > > reported by Checkstyle from 21844 to ... (complete with what you want > > ;-) > > > > PS: For code style, as discussed recently on this list, we are > > following Sun conventions. > > > > Gilles > > > > 2007/5/24, Xavier Hanin <[EMAIL PROTECTED]>: > > > On 5/24/07, Kevin Jackson <[EMAIL PROTECTED]> wrote: > > > > > > > > Hi all, > > > > > > > > > Hi Kevin, > > > > > > Would it be ok if I modified the code for style & javadoc? > > > > > > > > I know some people get quite upset when someone else starts working > on > > > > 'their code', so I thought I'd ask first :) > > > > > > > > > Sure, go ahead! This kind of contribution is really welcome! I don't > think > > > any of us we'll get upset to get a cleaner code base :-) > > > > > > Xavier > > > > > > Also of course I can only provide patches so if you don't like the > > > > changes just don't commit them :) > > > > > > > > Kev > > > > > > > > > > > > > > > > -- > > > Xavier Hanin - Independent Java Consultant > > > Manage your dependencies with Ivy! > > > http://incubator.apache.org/ivy/ > > > > > > > > > -- > > Gilles SCOKART > > > -- Xavier Hanin - Independent Java Consultant Manage your dependencies with Ivy! http://incubator.apache.org/ivy/
