On 5/30/07, Gilles Scokart <[EMAIL PROTECTED]> wrote:
I have just commited my pending changes. I guess the commit mail are again waiting to be unblocked. I registered myself with my apache email adress so that it doesn't happen again (but I did it after my commits :-( ). I don't have pending changes for the moment. Note that my commits includes a few '_' removal that I did before seeing the patch for that in jira. I commited it because the file was also containing some other change. I hope the merge of the patch will not be too heavy. Thanks to review my changes.
I've reviewed the changes and, wow, it's a lot of changes! I'm happy you can commit them yourself :-) From what I've seen so far everything seems very good. One thing we all have to consider: removing _ makes diff very verbose and difficult to review. So it would be nice if we manage to remove _ only in minor changes, or maybe even only in separate commits. It's not always possible, the idea being to clean the code when we touch it. But maybe in the future we could try when we make big changes to keep focused on the change and not on _ removal. WDYT? Xavier --
Gilles SCOKART
-- Xavier Hanin - Independent Java Consultant Manage your dependencies with Ivy! http://incubator.apache.org/ivy/
