Hi Mukul,

Mukul Gandhi <[email protected]> wrote on 07/24/2010 01:25:11 PM:

> Hi Michael,
>    Thanks for the explanation.
>
> I've made the corrections to the effected classes as you've suggested,
> and have committed the changes.

FYI: You missed one spot. I've just fixed it.

> This also solves the problem I was facing, as I mentioned in the
> previous mail.

Excellent.

> Many thanks.
>
> On Sat, Jul 24, 2010 at 10:33 PM, Michael Glavassevich
> <[email protected]> wrote:
> > No, not really. :-)
> >
> > You're not using the class as it was intended to be used. The bug is in
how
> > you were using the method, not in NamespaceSupport. Flipping
> > NamespaceSupport to use String.equals() has an impact on several
critical
> > code paths through Xerces. It hurts performance of the parser and other
> > components, so is not a change I would support.
> >
> > Wherever you call getPrefix() or getURI() you need to make sure that
the
> > string you're passing in has been interned (i.e. String.intern()) or
has
> > been passed through a SymbolTable [1].
>
> >
> > Thanks.
> >
> > [1]
> > http://xerces.apache.org/xerces2-j/javadocs/xerces2/org/apache/
> xerces/util/SymbolTable.html
> >
> > Michael Glavassevich
> > XML Parser Development
> > IBM Toronto Lab
> > E-mail: [email protected]
> > E-mail: [email protected]
>
>
>
> --
> Regards,
> Mukul Gandhi
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]

Thanks.

Michael Glavassevich
XML Parser Development
IBM Toronto Lab
E-mail: [email protected]
E-mail: [email protected]

Reply via email to