Hi Mukul, The PSVI interface looks much better now.
There was one other inconsistency which I just fixed. Instead of returning null when there are no inherited attributes, we should be returning an empty list as we do everywhere else in the API where lists are returned. Thanks. Michael Glavassevich XML Parser Development IBM Toronto Lab E-mail: mrgla...@ca.ibm.com E-mail: mrgla...@apache.org Mukul Gandhi <muk...@apache.org> wrote on 04/20/2011 12:09:01 PM: > Hi Michael, > I just now did a commit with few improvements to schema 1.1 > inheritable attributes PSVI implementation. > > Here's a summary of these corrections, > 1. org/apache/xerces/xni/XMLAttribute.java doesn't exist now and this > particular inappropriate dependency between XNI and XML Schema API > doesn't exist now. > 2. I'm now using ObjectList class to store inherited attributes. This > list is immutable and seemed to be an appropriate container for > inherited attributes. > 3. We're now using the complete AttributePSVI object to represent > inherited attributes. > > I hope these changes would be fine. Would be great if you could review > these changes and send comments if any. > > On Wed, Apr 20, 2011 at 7:23 AM, Michael Glavassevich > <mrgla...@ca.ibm.com> wrote: > > Hi all, > > > > Just catching up on recent changes and noticing the additions to the PSVI > > for XML Schema 1.1. > > > > I think we're going to need to revisit how inherited attributes are exposed. > > They're supposed to be a list of attribute information items and that is > > more than just a value and attribute declaration. Perhaps we should be using > > the full AttributePSVI to represent them. > > > > I also believe we should be consistent with the rest of the API which for > > collections returns immutable Lists instead of arrays (that can becorrupted > > by the user). > > > > Also need to be careful about introducing new dependencies into other > > layers. XNI has never had a dependency on the XML Schema API and I don't > > think it should. When we need a new schema specific interface for supporting > > new PSVI properties or a new schema component it really should be added to > > the XML Schema API (org.apache.xerces.xs.*). > > > > Thanks. > > > > Michael Glavassevich > > XML Parser Development > > IBM Toronto Lab > > E-mail: mrgla...@ca.ibm.com > > E-mail: mrgla...@apache.org > > > > > -- > Regards, > Mukul Gandhi > > --------------------------------------------------------------------- > To unsubscribe, e-mail: j-dev-unsubscr...@xerces.apache.org > For additional commands, e-mail: j-dev-h...@xerces.apache.org
