[
https://issues.apache.org/jira/browse/XERCESJ-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060521#comment-13060521
]
Michael Glavassevich commented on XERCESJ-1429:
-----------------------------------------------
Hi Thiwanka,
I assume you're referring to this code which checks the character offset and
produces progress events if the XMLLocator has advanced at least 2K:
public void startElement (QName element, XMLAttributes attributes,
Augmentations augs) throws XNIException {
if(locator.getCharacterOffset() == 0) {
reportProgressEvents();
nextCharOffset += 2048;
}else if(locator.getCharacterOffset() > nextCharOffset) {
reportProgressEvents();
nextCharOffset += 2048;
}
//Call the AbstractDOMParser.startElement()
super.startElement(element, attributes, augs);
}
That looks fine to me.
Just mentioned this to Ishara... In future it would be easier to review changes
if you created a patch (e.g. diff -u) which shows the differences between the
previous version. Generally also better to add source files as an attachment to
the JIRA issue rather than including it directly as a comment. This makes it
easier to review and apply to the codebase.
Thanks.
> [GSoC]: Asynchronous LSParser and parseWithContext
> --------------------------------------------------
>
> Key: XERCESJ-1429
> URL: https://issues.apache.org/jira/browse/XERCESJ-1429
> Project: Xerces2-J
> Issue Type: New Feature
> Components: DOM (Level 3 Load & Save)
> Affects Versions: 2.9.1
> Reporter: Michael Glavassevich
> Assignee: Thiwanka Somasiri
> Labels: gsoc2011
>
> The goal of this project is to complete the implementation of the DOM Level 3
> LSParser. Though Xerces has a functional LSParser, there are a couple parts
> of the spec which still need to be implemented. This includes an asynchronous
> [1] version which returns from the parse method immediately and builds the
> DOM tree on another thread as well as parseWithContext [2] which allows a
> document fragment to be parsed and attached to an existing DOM.
> Possible Mentors: Michael Glavassevich
> [1]
> http://www.w3.org/TR/2004/REC-DOM-Level-3-LS-20040407/load-save.html#LS-LSParser
> [2]
> http://www.w3.org/TR/2004/REC-DOM-Level-3-LS-20040407/load-save.html#LS-LSParser-parseWithContext
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: j-dev-h...@xerces.apache.org
