[ https://issues.apache.org/jira/browse/XERCESJ-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mukul Gandhi resolved XERCESJ-1692. ----------------------------------- Resolution: Not A Problem The code cited is in following java class, org.apache.xml.serialize.OutputFormat The documentation of this class says, "This class was deprecated in Xerces 2.9.0. It is recommended that new applications use the DOM Level 3 LSSerializer or JAXP's Transformation API for XML (TrAX) for serializing XML and HTML." Since this class was deprecated long time ago, I see very little benefit in making the improvement you've pointed (also, the improvement suggested is very cosmetic). Though I agree to this improvement, from the standpoint of current best practices for writing java code. > Inconsistent method name > ------------------------ > > Key: XERCESJ-1692 > URL: https://issues.apache.org/jira/browse/XERCESJ-1692 > Project: Xerces2-J > Issue Type: Improvement > Reporter: KuiLIU > Priority: Major > > The following method is named as "getIndenting", but the method checks > whether the indentation is specified or not. > So renaming the method as "isIndenting" should be more clear than > "getIndenting". > {code:java} > /** > * Returns true if indentation was specified. > */ > public boolean getIndenting() > { > return ( _indent > 0 ); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: j-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: j-dev-h...@xerces.apache.org