elharo commented on code in PR #8: URL: https://github.com/apache/xerces-j/pull/8#discussion_r2003543419
########## docs/security.xml: ########## @@ -0,0 +1,30 @@ +<?xml version='1.0' encoding='UTF-8'?> +<!-- + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. +--> +<!DOCTYPE s1 SYSTEM 'dtd/document.dtd'> +<s1 title="Security"> +<s2 title="Security Model"> + +By default, Xerces does what the XML specifications require. In some cases, this may not be appropriate behavior when working with untrusted input. There are multiple methods for blocking access to external entities and for disallowing DOCTYPE declarations, and it is up to the downstream user of Xerces-J to block/reject these constructs where appropriate. + +</s2> +<s2 title="Reporting"> + +If you think you have found a security issue in Apache Xerces, please follow the <jump href='https://security.apache.org/report-code'>reporting guidelines</jump>. Review Comment: It's worth adding a bit about not blindly reporting what static analyzers say as they're particularly bad at handling XML parsers. Adapted from the general guidelines: "Results from source code security analyzers are not accepted without additional analysis showing that the problem indeed violates the project's security model, as such tools commonly produce many false positives." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: j-dev-unsubscr...@xerces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: j-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: j-dev-h...@xerces.apache.org
