SingingBush commented on code in PR #2:
URL: https://github.com/apache/xerces-j/pull/2#discussion_r2162122515
##########
src/org/apache/xerces/dom/DOMImplementationListImpl.java:
##########
@@ -34,27 +35,27 @@
public class DOMImplementationListImpl implements DOMImplementationList {
// A collection of DOMImplementations
- private final ArrayList fImplementations;
+ private final List<DOMImplementation> fImplementations;
/**
* Construct an empty list of DOMImplementations
*/
public DOMImplementationListImpl() {
- fImplementations = new ArrayList();
+ fImplementations = new ArrayList<>();
}
/**
* Construct a list of DOMImplementations from an ArrayList
*/
- public DOMImplementationListImpl(ArrayList params) {
+ public DOMImplementationListImpl(List<DOMImplementation> params) {
Review Comment:
If I go back through the PR and ensure that all public signatures remain
as-is and only change private members would that be acceptable? Note that most
of the changes in this PR are within the `org.apache.xerces` package, certainly
any changes that would break compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
