elharo commented on code in PR #3:
URL: https://github.com/apache/xerces-j/pull/3#discussion_r2174704367
##########
build.xml:
##########
@@ -351,6 +351,7 @@ Authors:
org/w3c/dom/html/HTMLDOMImplementation.class"
manifest="${build.dir}/manifest.xerces">
<manifest>
+ <attribute name="Automatic-Module-Name"
value="org.apache.xerces.impl"/>
Review Comment:
Looking at Maven Central I think the only current jar is xerces:xercesImpl:
https://search.maven.org/search?q=g:xerces
In that case, I think org.apache.xerces.
However, if there's some sort of legacy issue here where the module name is
already xercesImpl and people depend on that, we should stick to that. I don't
think org.apache.xerces.impl is a good option though. "impl" generally implies
something that should be hidden from clients
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscr...@xerces.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: j-dev-h...@xerces.apache.org
