[ 
https://issues.apache.org/jira/browse/XERCESJ-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884073#comment-17884073
 ] 

Samael Bate edited comment on XERCESJ-1763 at 7/21/25 12:48 AM:
----------------------------------------------------------------

based on naming conventions for other Apache projects I suspect 
*org.apache.xerces.impl* would be the desired module name for the xercesImpl 
jar. 

I've created a PR for that as a starting point: 
[https://github.com/apache/xerces-j/pull/3]

 

Ideally xerces should fully support JPMS but there's quite a way to go on that 
due to the fact that xerces causes split packages, as it bundles 
org.w3c.dom.html. (also raised in XERCESJ-1760)

 

Until that's resolved and the library ships with a valid module-info.java 
defining an _Automatic-Module-Name_ in the jar's manifest is a step in the 
right direction.


was (Author: singingbush):
based on naming conventions for other Apache projects I suspect 
*org.apache.xerces.impl* would be the desired module name for the xercesImpl 
jar. 

I've created a PR for that as a starting point: 
[https://github.com/apache/xerces-j/pull/3]

 

Ideally xerces should fully support JPMS but there's quite a way to go on that 
due to the fact that xerces causes split packages, as it bundles 
org.w3c.dom.html.

 

Until that's resolved and the library ships with a valid module-info.java 
defining an _Automatic-Module-Name_ in the jar's manifest is a step in the 
right direction.

> Add Automatic-Module-Name to xercesImpl.jar manifest
> ----------------------------------------------------
>
>                 Key: XERCESJ-1763
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1763
>             Project: Xerces2-J
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Thomas Reinhardt
>            Priority: Major
>
> Adding an automatic module name makes the xercesImpl.jar usable in JPMS 
> enabled builds without affecting non-JPMS builds.
> Only a single line in MANIFEST.MF is needed:
> {code:java}
> Automatic-Module-Name: org.apache.xerces.impl{code}
>  
>  
> For ultimate compatibility the module name could be just _xercesImpl_ (which 
> is the module name derived from the filename). But that name does not follow 
> conventions.
> The proposed module name ({_}org.apache.xerces.impl{_}) also has problems as 
> it is not the super-package in the jar ({_}org.apache{_} is, but that clearly 
> is not usable either). But I think it clearly is a sensible name.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: j-dev-h...@xerces.apache.org

Reply via email to