elharo commented on code in PR #28:
URL: https://github.com/apache/xerces-j/pull/28#discussion_r2233456530
##########
src/org/apache/html/dom/HTMLDOMImplementationImpl.java:
##########
@@ -82,7 +82,7 @@ public final HTMLDocument createHTMLDocument( String title )
* used to perform operations that are not specific to a particular
* document instance, e.g. to create a new document.
*
- * @return Reference to a valid DOM implementation
+ * @return a singleton reference to a valid DOM implementation
Review Comment:
how do you know this is a singleton?
##########
src/org/apache/wml/WMLAElement.java:
##########
@@ -17,10 +17,9 @@
package org.apache.wml;
/**
- * <p>The interface is modeled after DOM1 Spec for HTML from W3C.
+ * The interface is modeled after DOM1 Spec for HTML from W3C.
* The DTD used in this DOM model is from
- * <a href="http://www.wapforum.org/DTD/wml_1.1.xml">
- * http://www.wapforum.org/DTD/wml_1.1.xml</a></p>
+ * <a
href="http://www.wapforum.org/DTD/wml_1.1.xml">http://www.wapforum.org/DTD/wml_1.1.xml</a>
Review Comment:
https
##########
build.xml:
##########
@@ -445,11 +445,11 @@ Authors:
<target name="javadoc-replace" unless="additional.param">
<replace token="@xerces.internal" dir="${build.src}">
- <replacevalue><![CDATA[<DL><DT><H1
style="font-size:110%">INTERNAL:</H1><DD>Usage of this class is not supported.
It may be altered or removed at any time.</DD></DT></DL>]]></replacevalue>
+ <replacevalue><![CDATA[<dl><dt>INTERNAL:</dt><dd>Usage of this class is
not supported. It may be altered or removed at any
time.</dd></dl>]]></replacevalue>
Review Comment:
I'd still use strong here
##########
src/org/apache/wml/WMLAccessElement.java:
##########
@@ -17,10 +17,9 @@
package org.apache.wml;
/**
- * <p>The interface is modeled after DOM1 Spec for HTML from W3C.
+ * The interface is modeled after DOM1 Spec for HTML from W3C.
* The DTD used in this DOM model is from
- * <a href="http://www.wapforum.org/DTD/wml_1.1.xml">
- * http://www.wapforum.org/DTD/wml_1.1.xml</a></p>
+ * <a
href="http://www.wapforum.org/DTD/wml_1.1.xml">http://www.wapforum.org/DTD/wml_1.1.xml</a>
Review Comment:
https
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]