elharo commented on code in PR #39:
URL: https://github.com/apache/xerces-j/pull/39#discussion_r2464100467
##########
src/org/apache/xml/serialize/BaseMarkupSerializer.java:
##########
@@ -1394,6 +1388,12 @@ protected void serializePreRoot()
// Text pretty printing and formatting methods //
//---------------------------------------------//
+ /**
+ * Prints the CDATA text to the underlying Printer
Review Comment:
needs period
##########
src/org/apache/xml/serialize/BaseMarkupSerializer.java:
##########
@@ -688,58 +688,52 @@ public void comment( String text )
state.afterElement = false;
}
-
+ /**
+ * Start serializing as CDATA section
+ */
public void startCDATA()
{
- ElementState state;
-
- state = getElementState();
- state.doCData = true;
+ getElementState().doCData = true;
}
-
+ /**
+ * End serializing as CDATA section
Review Comment:
needs period
##########
src/org/apache/xml/serialize/Printer.java:
##########
@@ -115,6 +120,12 @@ public Printer( Writer writer, OutputFormat format)
}
+ /**
+ * If the serializer encountered an en exception it is held until the
serializer finishes.
Review Comment:
"en"?
##########
src/org/apache/xml/serialize/BaseMarkupSerializer.java:
##########
@@ -688,58 +688,52 @@ public void comment( String text )
state.afterElement = false;
}
-
+ /**
+ * Start serializing as CDATA section
Review Comment:
needs period
##########
src/org/apache/xml/serialize/BaseMarkupSerializer.java:
##########
@@ -688,58 +688,52 @@ public void comment( String text )
state.afterElement = false;
}
-
+ /**
+ * Start serializing as CDATA section
+ */
public void startCDATA()
{
- ElementState state;
-
- state = getElementState();
- state.doCData = true;
+ getElementState().doCData = true;
}
-
+ /**
+ * End serializing as CDATA section
+ */
public void endCDATA()
{
- ElementState state;
-
- state = getElementState();
- state.doCData = false;
+ getElementState().doCData = false;
}
-
+ /**
+ * Start serializing as raw characters
Review Comment:
needs period
##########
src/org/apache/xml/serialize/BaseMarkupSerializer.java:
##########
@@ -688,58 +688,52 @@ public void comment( String text )
state.afterElement = false;
}
-
+ /**
+ * Start serializing as CDATA section
+ */
public void startCDATA()
{
- ElementState state;
-
- state = getElementState();
- state.doCData = true;
+ getElementState().doCData = true;
}
-
+ /**
+ * End serializing as CDATA section
+ */
public void endCDATA()
{
- ElementState state;
-
- state = getElementState();
- state.doCData = false;
+ getElementState().doCData = false;
}
-
+ /**
+ * Start serializing as raw characters
+ */
public void startNonEscaping()
{
- ElementState state;
-
- state = getElementState();
- state.unescaped = true;
+ getElementState().unescaped = true;
}
-
+ /**
+ * End serializing as raw characters
Review Comment:
needs period
##########
src/org/apache/xml/serialize/Printer.java:
##########
@@ -104,6 +104,11 @@ public class Printer
private int _pos = 0;
+ /**
+ * Create a new Printer instance with the desired char stream and output
format.
+ * @param writer an output char stream that will be written to
Review Comment:
blank line before first tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
