elharo commented on code in PR #44:
URL: https://github.com/apache/xerces-j/pull/44#discussion_r2503174585
##########
src/org/apache/xerces/stax/events/CharactersImpl.java:
##########
@@ -39,9 +39,13 @@ public final class CharactersImpl extends XMLEventImpl
implements Characters {
/**
* Standard constructor.
- * @param eventType
- * @param location
- * @param schemaType
+ *
+ * @param data the text characters of this event
+ * @param eventType int value representing the type of this event. {@see
javax.xml.stream.XMLStreamConstants}
+ * @param location Location object for this event.
Review Comment:
no period
##########
src/org/apache/xerces/stax/events/EntityDeclarationImpl.java:
##########
@@ -40,9 +40,13 @@ public final class EntityDeclarationImpl extends
XMLEventImpl implements
private final String fNotationName;
/**
- * @param eventType
- * @param location
- * @param schemaType
+ * Constructor for an implementation of {@link EntityDeclaration}.
+ *
+ * @param publicId the publicId
Review Comment:
don't just repeat the argument name; might as well leave it out in that case
##########
src/org/apache/xerces/xs/datatypes/package.html:
##########
@@ -29,192 +29,192 @@
<TABLE border="1">
<TBODY>
<TR>
- <TD width="332" align="center">XML Schema Data Type</TD>
- <TD align="center" width="202">Interface/Class</TD>
+ <TD>XML Schema Data Type</TD>
Review Comment:
don't just get rid of these attributes. perhaps remove this file from this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
