elharo commented on code in PR #48:
URL: https://github.com/apache/xerces-j/pull/48#discussion_r2532256922
##########
src/org/apache/xerces/parsers/XMLGrammarParser.java:
##########
@@ -23,6 +23,8 @@
import org.apache.xerces.xni.parser.XMLParserConfiguration;
/**
+ * XML Grammar Parser
Review Comment:
ditto
##########
src/org/apache/xerces/xni/XMLString.java:
##########
@@ -154,8 +154,9 @@ public boolean equals(char[] ch, int offset, int length) {
/**
* Returns true if the contents of this XMLString structure and
* the specified string are equal.
- *
- * @param s The string to compare.
+ *
+ * @param s the string to compare
+ * @return true if the contents of this XMLString match the string
Review Comment:
Java string
##########
src/org/apache/xerces/xs/datatypes/XSDateTime.java:
##########
@@ -205,57 +205,68 @@
public interface XSDateTime {
/**
+ * Returns years.
Review Comment:
again, I wouldn't add these just to have some text there
##########
src/org/apache/xerces/parsers/DTDParser.java:
##########
@@ -29,6 +29,8 @@
import org.apache.xerces.xni.parser.XMLDTDScanner;
/**
+ * DTD Parser
Review Comment:
I think I generally prefer no comment to one that more-or-less repeats the
class/method/field name. This sweeps the warning under the rug but it doesn't
fix the real issue.
##########
src/org/apache/xerces/xs/XSElementDeclaration.java:
##########
@@ -79,11 +93,18 @@ public Object getActualVC()
* constraint value of the list or list of union type definitions use
* <code>itemValueTypes</code>. If the <code>actualNormalizedValue</code>
* is <code>null</code>, this method returns <code>UNAVAILABLE_DT</code>.
- * @exception XSException
- * NOT_SUPPORTED_ERR: Raised if the implementation does not support this
- * method.
+ *
+ * @return s short value for one of the specified {@link XSConstants}
Review Comment:
delete "s short value for "
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
