elharo commented on code in PR #64:
URL: https://github.com/apache/xerces-j/pull/64#discussion_r2555814108
##########
src/org/apache/html/dom/HTMLDocumentImpl.java:
##########
@@ -614,23 +644,33 @@ public void close()
}
}
-
+ /**
+ * Write a string into the in-memory writer.
Review Comment:
The in-memory writer is an implementation detail not exposed to the client
so it shouldn't be referenced in the docs. Also, this doesn't really work here.
It might in subclasses. Per class comment, "Note: <FRAMESET> documents
are not supported at the moment, neither are direct document writing ({@link
#open}, {@link #write})"
##########
src/org/apache/xerces/dom/NamedNodeMapImpl.java:
##########
@@ -328,14 +326,21 @@ public Node removeNamedItemNS(String namespaceURI, String
name)
/**
* Cloning a NamedNodeMap is a DEEP OPERATION; it always clones
* all the nodes contained in the map.
+ *
+ * @param ownerNode the owner node that this node's children will be
cloned to
+ * @return a collection of Nodes containing this node's children
*/
-
public NamedNodeMapImpl cloneMap(NodeImpl ownerNode) {
NamedNodeMapImpl newmap = new NamedNodeMapImpl(ownerNode);
newmap.cloneContent(this);
return newmap;
}
+ /**
+ * Override parent's method to set the ownerNode correctly.
+ *
+ * @param srcmap a NamedNodeMap who's nodes will be cloned into this
NamedNodeMap's instance
Review Comment:
whose nodes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
