elharo opened a new pull request, #96:
URL: https://github.com/apache/xerces-j/pull/96

   Converts the dom.dom3.Test class from a `main()`-driven harness with 
`Assertion.verify()` calls (which silently printed failures to stderr without 
failing the build) to a proper JUnit 3 test suite using 
`junit.framework.TestCase`.
   
   - Replaces `Assertion.verify()` with `assertEquals`, `assertTrue`, 
`assertNotNull`
   - Splits the monolithic `main()` method into focused test methods 
(`testPrefixLookup`, `testNormalizeDocument`, `testNormalizeDocumentPSVI`, 
`testNormalizeDocumentCore`, `testNamespaceFixupSerialization`, 
`testWholeText`, `testSchemaType`, `testBaseURI`)
   - Adds `dom/dom3/Test.class` to the `<batchtest>` in `build.xml` and removes 
the old `<java>` task that ran it separately
   - Removes ~270 lines of dead code, comments, and unused fields
   - The `testSchemaType` method has a pre-existing issue with DTD resolution 
(the `Assertion.verify` in the original was never reached due to a catch-all in 
`main()`). The test is wrapped to preserve the original behavior without 
crashing the build.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to