Copilot commented on code in PR #125: URL: https://github.com/apache/xerces-j/pull/125#discussion_r4492780331
########## tests/org/apache/xerces/impl/dv/xs/TestDateDV.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.xerces.impl.dv.xs; Review Comment: Putting this test in the production package causes it to be shipped in xercesImpl.jar when packaging after tests (for example, `ant test jar`). The `tests` target compiles into `${build.dest}` (build.xml:374–375), and the `jar` target packages `org/apache/**` from that same directory (build.xml:333–336), including this JUnit-dependent class. Move the test to a package outside the production include patterns and update its batch-test entry, or explicitly exclude test classes from the production jars. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
