Hi all,
We need more Xalan pmc reviews, to have this RC declared to be approved.
On Sun, Mar 26, 2023 at 6:22 PM Gary Gregory <garydgreg...@gmail.com> wrote:
>
> Thank you Mukul for this RC.
>
> +1
>
> - Reviewing src zip: ASC, SHA files OK.
> - Building runtime with 'chmod +x ./build.sh && ./build.sh clean fulldist' OK.
> - Following the README, there is confusion because the unzipped src zip
> creates a `xalan-test` folder as a child folder but the README describes it
> as a sibling folder. Does this skew the tests or cause issues?
> - TODOs later:
> -- Fix Javadoc errors
> -- Test output should be quieter in non-debug mode: No need to tell me all
> the test files that PASS, I have no idea if I am missing any failure output
> without tediously reviewing ALL console output.
>
> Using:
>
> ant -version
> Apache Ant(TM) version 1.10.13 compiled on January 4 2023
>
> java -version
> openjdk version "1.8.0_362"
> OpenJDK Runtime Environment (build 1.8.0_362-bre_2023_01_22_03_32-b00)
> OpenJDK 64-Bit Server VM (build 25.362-b00, mixed mode)
>
> uname -a
> Darwin *** 22.3.0 Darwin Kernel Version 22.3.0: Mon Jan 30 20:42:11 PST 2023;
> root:xnu-8792.81.3~2/RELEASE_X86_64 x86_64
>
> Gary
--
Regards,
Mukul Gandhi
