#34: jabberd wrapper script was designed to invoke components in different
directories but ignored
-------------------+--------------------------------------------------------
Reporter: smoku | Owner: smoku
Type: defect | Status: assigned
Priority: major | Component: General
Version: 2.1 | Resolution:
Keywords: |
-------------------+--------------------------------------------------------
Changes (by smoku):
* status: new => assigned
Old description:
> change:
> push(@programs,[$job,$config,$cmd]);
>
> to:
> push(@programs,[$job,$config]);
>
> in jabberd.in
>
> ------- Comment #1 From bob humphrey 2005-04-11 15:41 [reply] -------
>
> But, to whoever can commit this, does removal of setting that "my $cmd"
> line
> affect any other part of the script? it's not obvious to me that it does
> (but
> it was written this way for some reason eh?), but someone might want to
> double
> check - please let me know what you think - I run the change to the push
> line
> in production currently, but don't feel like removing that other "my
> $cmd" line
> until the weekend (when I have no users on) to test....
>
> --- jabberd.in.original Mon Apr 11 15:32:46 2005
> +++ jabberd.in Mon Apr 11 15:34:20 2005
> @@ -108,11 +108,7 @@
> next if /^\#/;
> next if /^\s*$/;
> my ($job,$config) = /^\s*(\S+)\s*(\S*)\s*$/;
> - # Assume that all the commands are in the same directory
> - # as the jabberd script. The current configuration file
> - # format does not allow specification of pathnames for commands.
> - my $cmd = "$Bin/$job";
> - push(@programs,[$job,$config,$cmd]);
> + push(@programs,[$job,$config]);
> }
> close(CFG);
> }
>
> ------- Comment #2 From Stephen Marquard 2005-08-21 13:57 [reply] -------
>
> Changes to the jabberd wrapper script should also consider the feedback
> below.
> Clearly FindBin fails under some circumstances on some platforms.
>
> ------- Forwarded message follows -------
> Date sent: Fri, 8 Jul 2005 05:57:08 -0700 (PDT)
> From: Arpad Biro <[EMAIL PROTECTED]>
> Subject: Jabberd "Use of uninitialized value" bug
> To: [EMAIL PROTECTED]
>
> Hi,
>
> I wanted to write some comment to this Jabber bug:
> http://www.jabberstudio.org/projects/jabberd2/bugs/view.php?id=4060
>
> but wasn't able to do so, possibly because that bug is already closed.
>
> So now I'm giving info in email.
> That bug is also present in jabberd-2.0s7, and I found a solution.
> The bug is caused by FindBin returning an empty value, and thus
> the following instructions (in /usr/local/bin/jabberd) fail:
>
> $jobs{router}->{cmd} = "$Bin/router";
> $jobs{resolver}->{cmd} = "$Bin/resolver";
> $jobs{sm}->{cmd} = "$Bin/sm";
> $jobs{c2s}->{cmd} = "$Bin/c2s";
> $jobs{s2s}->{cmd} = "$Bin/s2s";
>
> Adding a
> $Bin="/usr/local/bin";
> line before the above mentioned ones solved the problem.
>
> Shall I open a new bug report on this or is this info enough?
>
> Arpad Biro
New description:
change:
push(@programs,[$job,$config,$cmd]);
to:
push(@programs,[$job,$config]);
in jabberd.in
------- Comment #1 From bob humphrey 2005-04-11 15:41 [reply] -------
But, to whoever can commit this, does removal of setting that "my $cmd"
line
affect any other part of the script? it's not obvious to me that it does
(but
it was written this way for some reason eh?), but someone might want to
double
check - please let me know what you think - I run the change to the push
line
in production currently, but don't feel like removing that other "my $cmd"
line
until the weekend (when I have no users on) to test....
{{{
--- jabberd.in.original Mon Apr 11 15:32:46 2005
+++ jabberd.in Mon Apr 11 15:34:20 2005
@@ -108,11 +108,7 @@
next if /^\#/;
next if /^\s*$/;
my ($job,$config) = /^\s*(\S+)\s*(\S*)\s*$/;
- # Assume that all the commands are in the same directory
- # as the jabberd script. The current configuration file
- # format does not allow specification of pathnames for commands.
- my $cmd = "$Bin/$job";
- push(@programs,[$job,$config,$cmd]);
+ push(@programs,[$job,$config]);
}
close(CFG);
}
}}}
------- Comment #2 From Stephen Marquard 2005-08-21 13:57 [reply] -------
Changes to the jabberd wrapper script should also consider the feedback
below.
Clearly FindBin fails under some circumstances on some platforms.
------- Forwarded message follows -------
Date sent: Fri, 8 Jul 2005 05:57:08 -0700 (PDT)
From: Arpad Biro <[EMAIL PROTECTED]>
Subject: Jabberd "Use of uninitialized value" bug
To: [EMAIL PROTECTED]
Hi,
I wanted to write some comment to this Jabber bug:
http://www.jabberstudio.org/projects/jabberd2/bugs/view.php?id=4060
but wasn't able to do so, possibly because that bug is already closed.
So now I'm giving info in email.
That bug is also present in jabberd-2.0s7, and I found a solution.
The bug is caused by FindBin returning an empty value, and thus
the following instructions (in /usr/local/bin/jabberd) fail:
$jobs{router}->{cmd} = "$Bin/router";
$jobs{resolver}->{cmd} = "$Bin/resolver";
$jobs{sm}->{cmd} = "$Bin/sm";
$jobs{c2s}->{cmd} = "$Bin/c2s";
$jobs{s2s}->{cmd} = "$Bin/s2s";
Adding a
$Bin="/usr/local/bin";
line before the above mentioned ones solved the problem.
Shall I open a new bug report on this or is this info enough?
Arpad Biro
--
Ticket URL: <http://jabberd2.xiaoka.com/ticket/34#comment:1>
jabberd2 <http://jabberd2.xiaoka.com/>
jabberd2 project
_______________________________________________
jabberd2 mailing list
[EMAIL PROTECTED]
http://lists.xiaoka.com/listinfo.cgi/jabberd2-xiaoka.com
