#17: PAM module uses bogus username
-------------------+--------------------------------------------------------
Reporter: smoku | Owner: smoku
Type: defect | Status: closed
Priority: major | Component: c2s
Version: 2.1 | Resolution: invalid
Keywords: | Blocking:
-------------------+--------------------------------------------------------
Comment (by sxw):
What you're outlining is the way it _should_ work - currently there's no
way of setting a '' or empty realm that makes it past the config file
parser
Currently - when you set an empty value, or do not set it all, the
configuration parser sets the realm to be the same as the <id>. So, for
instance ... <id>inf.ed.ac.uk</id> - results in the realm parameter of the
host structure being set to "inf.ed.ac.uk".
Relevant code is in c2s/main.c ...
realm = j_attr((const char **) elem->attrs[i], "realm");
[ ... ]
host->realm = (realm != NULL) ? realm :
pstrdup(xhash_pool(c2s->hosts), id);
As you can't (currently) set the realm attribute to an empty string due to
the way that attribute parsing works, there is currently no way of setting
an empty realm. Gettting rid of the check will break everyone who's not
specifiying the realm, and
relying on the current behaviour. I think a fix needs to be able to
differentiate between when the realm isn't specified, and when it's
specified as an empty string.
I have a fix for this problem which I can attach, if that would make
things clearer.
Simon.
--
Ticket URL: <http://jabberd2.xiaoka.com/ticket/17#comment:5>
jabberd2 <http://jabberd2.xiaoka.com/>
jabberd2 project
_______________________________________________
jabberd2 mailing list
[email protected]
http://lists.xiaoka.com/listinfo.cgi/jabberd2-xiaoka.com
