[ http://issues.apache.org/jira/browse/JCR-256?page=all ]
Marcel Reutegger resolved JCR-256:
----------------------------------
Resolution: Fixed
Thanks for your comments. I've committed the patch as is. I didn't touch the
name package, because it is not urgent to me to resolve that issue.
- added decoration for all required jcr interfaces
- added more factory methods to DecoratorFactory
- renamed SimpleDecoratorFactory to DefaultDecoratorFactory
- removed ChainedDecoratorFactory and ChainedItemDecorator
- added sample decorator: TrussDecoratorFactory
svn revision: 326437
> Improve jcr decorator in jcr-ext
> --------------------------------
>
> Key: JCR-256
> URL: http://issues.apache.org/jira/browse/JCR-256
> Project: Jackrabbit
> Type: Improvement
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Minor
> Attachments: jcr-decorator.patch
>
> The jcr decorator in jcr-ext does not cover all the necessary interfaces of
> the jcr api. It may happen that a client loses the decoration layer when
> accessing properties.
> I've added decoration for several jcr interfaces to ensure that the
> decoration layer is never left.
> The attached patch also removes the classes related to decorator chaining. I
> found it hard to understand the purpose of those classes and decided to
> remove them from the default implementation. If we want to keep those classes
> they should be less intrusive.
> I've also noticed that there are class name clashes, specifically the package
> org.apache.jackrabbit.name contains classes that are also present in the
> jackrabbit and jackrabbit-commons jar file. I propose to move the respective
> classes in jcr-ext to a different package or remove them in favor of the
> jackrabbit-commons classes.
> Let me know if I should commit the the patch.
> Thanks
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
