[ http://issues.apache.org/jira/browse/JCR-306?page=comments#action_12363253 ]
Tobias Bocanegra commented on JCR-306: -------------------------------------- i strongly oppose to apply the suggested patch. stefan is right - the internals of jackrabbit rely on the fact that the config classes are immutable. we should not break this. i suggest to create some sort of ConfigBuilder which has all the relevant getter and setter methods, and a 'create()' method that creates the immutable config objects. > repositoryConfig should use setter for its internal components > -------------------------------------------------------------- > > Key: JCR-306 > URL: http://issues.apache.org/jira/browse/JCR-306 > Project: Jackrabbit > Type: Improvement > Components: config > Reporter: Costin Leau > Assignee: Jukka Zitting > Fix For: 0.9 > Attachments: RepositoryConfig.patch > > From the mailing list (not archived at the moment): > --- Jukka's reply --- > I refactored the config classes last year but didn't change the way > the config instances are being used by Jackrabbit. In general I think > that a IoC approach (use setters to configure the Jackrabbit > components) would be better than passing config objects around and > letting the components to instantiate any subcomponents based on the > configuration. This is why I didn't really want to make the config > constructors public, otherwise we'd easily up with backwards > compatibility issues if we were to change the way configuration is > handled. > --- -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
