Thanks (I have never participated in open source projects, not that familiar with everything). Now when I actually did the pull request I started to think the implications of the change.. The quick-to-fix approach to call ensureMore() just to reallocate the buffer (when it is not even necessary in some cases) could be replaced with a more elegant solution...
On Tuesday, March 7, 2017 at 8:56:25 PM UTC+2, Tatu Saloranta wrote: > > Yes, PR is the usual way (fork, then submit a Pull Request). > It would be great to get a fix contributed to help others, looking > forward to it! > > -+ Tatu +- > > On Tue, Mar 7, 2017 at 10:54 AM, Nikolai Riikonen > <[email protected] <javascript:>> wrote: > > Hi, > > > > I filed an issue yesterday > > (https://github.com/FasterXML/jackson-dataformats-binary/issues/54) but > > since we are in a hurry to get this fixed I already fixed it myself. > > Is there a way to push a new branch to the repository for review? > > > > It's specific to protobuf, not related to other dataformats. > > > > -- > > You received this message because you are subscribed to the Google > Groups > > "jackson-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send > an > > email to [email protected] <javascript:>. > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "jackson-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
