Just guessing: Arquilian builds an agent of it's own based on jacoco-core which is deployed to/running as part of Wildfire formerly-known-as-jboss. WF uses asm4. To ease building the arquilian-jacoco-agent a shaded jar could be helpful. Drawback: it has a similar but distinct API.
Regards Mirko -- Sent from my mobile On Nov 2, 2014 9:31 AM, "Marc R. Hoffmann" <[email protected]> wrote: > Hi John, > > ASM5 is required for Java 8 support. > > We already deliver two artifacts with shaded ASM5 included: > > 1) The JaCoCo agent itself (here even jacoco itself is relocated to a > random package name to allow running JaCoCo on JaCoCo) > 2) The jacocoant.jar which is part of the all-in-download distribution > > I don't think we can shade ASM for org.jacoco.core as ASM is part of the > API here (more API to come once we have filtering). My assumption is that > we should only apply shading for "stand alone tools" which do not provide a > Java API. > > John, what is the specific situation where you run in trouble? Runtime? > Analysis/Report generation time? I'm not familiar with the Arquillian > architecture. > > Cheers, > -marc > > > On 02.11.14 01:15, John D. Ament wrote: > > So, I wanted to run this idea by the JaCoCo folks. > > I'm somewhat affiliated with Arquillian. Today I ran into an issue when > someone upgraded the Arquillian JaCoCo extension to 0.7.1 and Java 8 > support. While a great idea, looks like you did this by upgrading to ASM 5 > as well. > > The problem is that ASM 5 isn't compatible w/ WildFly 8.1 (at least not > yet) due to some JAX-WS dependencies. I'm able to work around this issue > in Arquillian by creating a shaded JAR based on JaCoCo and ASM 5, where ASM > 5 gets relocated to a different package. However before that goes in, I > have to ask - would you be willing to distribute a shaded JAR w/ a > relocation of ASM 5 to avoid this upgrade compatibility issue? > > I did a quick POC locally and it did work just as well. You can see the > changes here: > https://github.com/johnament/jacoco/commit/8bc85be663005ab490dadbdb76dfee0a13f4033d > > If you're interested in the additional distribution, I can raise a PR to > merge my code into JaCoCo to create the shaded JAR. > > Let me know. > > John > -- > You received this message because you are subscribed to the Google Groups > "JaCoCo and EclEmma Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google Groups > "JaCoCo and EclEmma Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "JaCoCo and EclEmma Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
