On Thu, Mar 29, 2018 at 6:58 PM Marc Hoffmann <[email protected]>
wrote:

> Here is a proposed fix:
>
> https://github.com/jacoco/jacoco/pull/667
>
> I didn't yet expand it to other validation tests as they depend on the
> toolchain JDK.
>
> Not sure I understand what do you mean by  "depends on the toolchain JDK".
Isn't it as simple as making assertion on classfiles that have version less
than 1.5 - see "checkAbsenceOfFrames" in "AIOOBETest" in attachment to one
of previous emails.

Ok, we can add this later, but IMO we should have such check in validation
tests, because I have feeling that this might actually be a regression -
see comments in PR.

-- 
You received this message because you are subscribed to the Google Groups 
"JaCoCo and EclEmma Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jacoco/CAEPFu6-oq%2Bnv9NThx-Rzn4rVxhFEv%2B0%3DDpVR%3DZct-HjraK0bxg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to