Hi, On 06/29/16 07:57, Jan Kiszka wrote: > On 2016-06-09 14:18, Xuguo Wang wrote: >> *** >> This patch includes three parts: >> 1 IOPortRegion hierarchy generate >> 2 parse ioports redefine >> 3 pio_bitmap template modify >> *** >> >> Xuguo Wang (3): >> tools: Add the hierarchy of the IOPortRegion. >> tools: Refactor the parse ioports function. >> tools: Modify the template of the root cell config. >> >> tools/jailhouse-config-create | 489 >> ++++++++++++++++++++++++++++++++++++++---- >> tools/root-cell-config.c.tmpl | 21 +- >> 2 files changed, 452 insertions(+), 58 deletions(-) >> > > Ralf, Valentine, when you have time, please check if this version > addressed your remarks. I just created a system config with next and Xuguo's patch set and diffed the configs.
>From what I can see, the output looks good. Unfortunately, none of my x86 machines have serial interfaces, so I can not test it. Maybe someone of you could test it and report. I have some comments on patch 2/3. Still, even if the code is functional, I think we should really pay more attention on comments... Valentine, do you have any further remarks? Ralf > > Thanks, > Jan > -- Ralf Ramsauer PGP: 0x8F10049B -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
