just the style issue, for example,: >On 03.06.2016 12:35, Xuguo Wang wrote: >> >> Abstract the common property of the ioports from the >> /proc/ioports as the super class named IOPortRegion, >> using the region of ioports form the IOPortRegionTree, >> this tree includes all of the ioport regions we could >> use this regions generate the pio_bitmap. >> >> Signed-off-by: Xuguo Wang <[email protected]> >> --- >> tools/jailhouse-config-create | 161 >> ++++++++++++++++++++++++++++++++++-------- >> 1 file changed, 131 insertions(+), 30 deletions(-) >> >> diff --git a/tools/jailhouse-config-create b/tools/jailhouse-config-create >> index 4e61abc..c545c1c 100755 >> --- a/tools/jailhouse-config-create >> +++ b/tools/jailhouse-config-create >> @@ -368,18 +368,27 @@ class PCIPCIBridge(PCIDevice): >> return (secondbus, subordinate) >> >> >> -class MemRegion: >> - def __init__(self, start, stop, typestr, comments=None): >> +# super class of IOMemRegion and IOPortRegion >> +class IORegion:
>Any reason for using old-style objects instead of 'class IORegion(object)' >here? This the valentine addressed, and refactor the function of >> >> + @staticmethod >> + def parse_line(regionclass, line): >Having regionaclass as the first argument here strongly suggests you want >@classmethod, not @staticmethod here. Is there a way to refactor your code? I think these advice could be done after these patch.. best regards from Xuguo Wang 2016-06-30 18:06 GMT+08:00 Jan Kiszka <[email protected]>: > On 2016-06-30 12:01, Xuguo Wang wrote: >> *** >> This patch includes three parts: >> 1 IOPortRegion hierarchy generate >> 2 parse ioports redefine >> 3 pio_bitmap template modify >> >> PS. >> Sorry, I have not done about refactoring the python code >> style from 2.7 to the 3.0, since I think maybe this should >> be done after the main purpose of these patches. > > Is this a style issue, or does it mean the code will not run against > Python 3? Breakages have to be fixed before merging. > > Jan > >> *** >> >> Xuguo Wang (3): >> tools: Add the hierarchy of the IOPortRegion. >> tools: Refactor the parse ioports function. >> tools: Modify the template of the root cell config. >> >> tools/jailhouse-config-create | 488 >> ++++++++++++++++++++++++++++++++++++++---- >> tools/root-cell-config.c.tmpl | 21 +- >> 2 files changed, 451 insertions(+), 58 deletions(-) >> > -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
