On 2016-08-04 21:28, Ralf Ramsauer wrote: > Hi, > > this is a short series that does not introduce any functional changes. > > I'd like to replace jailhouse-cell-list. It's a rudimentary function and > requires python. So I reimplemented cell-list natively in C and did some > cleanup work on tools/jailhouse.c. > > First three patches are only housekeeping work. tools/jailhouse.c didn't > respect > the return values of close(). Though it's very unlikely that close() fails, > return values should be checked. I introduced a global file descriptor to > minimise > the occurence of open()s and close()s. > > Fourth patch introduces some preparatory changes on read_file() as we need to > read > files from sysfs. > > Fifth patch is discussible. I don't know if it's a good idea to change the > output > format of /sys/devices/jailhouse/cells/*/cpus_*. On the other hand -- who's > gonna > parse it? I'm open for comments on that.
sysfs is primarily about being machine-readable, but your patch works a bit against this. E.g., the libvirt driver for Jailhouse may want to (or already does - didn't check) make use of that information. If at all, it has to be an additional node that exposes the information in human-readable format. You still need to explain more clearly why we need beautified cell listing as core feature of the tool. Or IOW, which use case is behind having a minimal Linux system without Python and, thus, also without the add-on scripts that is still frequently human-operated (there is still sysfs for infrequent checks). Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
