On 2016-12-07 20:56, Jan Kiszka wrote:
> On 2016-12-07 14:37, Ralf Ramsauer wrote:
>> Python code shall run under Python 2 and Python 3. This fix is required
>> to run the linux loader under Python 3.
>>
>> Basically the same fix as 5f286d2514f2 ("tools: make
>> jailhouse-cell-linux run under Python3")
>>
>> Fixes: 077e62e372c ("tools: Add ARM and ARM64 support to Linux loader
>> script")
>> Signed-off-by: Ralf Ramsauer <[email protected]>
>> ---
>> tools/jailhouse-cell-linux | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/jailhouse-cell-linux b/tools/jailhouse-cell-linux
>> index b5806e0dec1a..f65d957cce96 100755
>> --- a/tools/jailhouse-cell-linux
>> +++ b/tools/jailhouse-cell-linux
>> @@ -339,6 +339,7 @@ class ARMCommon:
>>
>> self.params = 'kernel=0x%x dtb=0x%x' % (self._kernel_addr,
>> self._dtb_addr)
>> + self.params = self.params.encode('utf-8')
>>
>> self.dtb = DTB(args.dtb.read())
>>
>>
>
> Hmm, tested this, but only via --write-params. Apparently, that wasn't
> sufficient.
>
> But it seems we do not apply the encoding parameter consistently. What
> should be done, rely on default or specify utf-8 explicitly?
OK, default is already 'utf-8', so the the above explicit mentioning is
just redundant. I will merge this nevertheless and maybe file a patch
that removes all the default repetitions from the script with proper
reasoning.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
--
You received this message because you are subscribed to the Google Groups
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
