On 01/24/2017 05:29 PM, Jan Kiszka wrote: > On 2017-01-19 21:11, Ralf Ramsauer wrote: >> From now on, 'jailhouse enable' will dump the console if an error occurs >> during initialisation of the hypervisor. >> >> Signed-off-by: Ralf Ramsauer <[email protected]> >> --- >> tools/jailhouse.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/tools/jailhouse.c b/tools/jailhouse.c >> index ede6ad4412..904c0658f3 100644 >> --- a/tools/jailhouse.c >> +++ b/tools/jailhouse.c >> @@ -234,8 +234,10 @@ static int enable(int argc, char *argv[]) >> fd = open_dev(); >> >> err = ioctl(fd, JAILHOUSE_ENABLE, config); >> - if (err) >> + if (err) { >> perror("JAILHOUSE_ENABLE"); >> + dump_console(fd, true); >> + } >> >> close(fd); >> free(config); >> > > Wondering if we should do the same on errors of other commands, but then > only the delta... Yes, would be easy. But the hypervisor console output isn't really helpful in those cases right now. > > In its simple form, this patch is > > Reviewed-by: Jan Kiszka <[email protected]> Again, thanks for the review.
Most of your comments are already addressed, please find v5 here: https://github.com/lfd/jailhouse/tree/hvconsoleV5 (still have to find a proper name for jailhouse_console_delta) Ralf > > Jan > -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
