On Tue, 7 Feb 2017 18:11:05 +0100 Jan Kiszka <[email protected]> wrote:
> On 2017-02-07 13:32, Henning Schild wrote: > > If the root-cell kernel is built with GCOV (CONFIG_GCOV_PROFILE_ALL) > > kbuild will build everything with GCOV support. For the driver it is > > ok to inherit that, but for out of kernel parts like hypervisor, > > tools, inmates it is not. > > > > Signed-off-by: Henning Schild <[email protected]> > > > > diff --git a/configs/Makefile b/configs/Makefile > > --- a/configs/Makefile > > +++ b/configs/Makefile > > @@ -22,6 +22,8 @@ > > > > OBJCOPYFLAGS := -O binary > > > > +GCOV_PROFILE := n > > + > > Configs (and also the device trees in dts - you skipped them already) > do not contain code. So this is not needed. Yes but configs get compiled with gcc which means they are build with the special gcov CFLAGS and output the .gcno files even without containing code. That is why i kept the change in v2. For dts we do not have "%.o: %.c" but we could add the line for consistency. > > CONFIGS = $(shell cd $(src); ls *.c) > > > > always := $(CONFIGS:.c=.cell) > > diff --git a/hypervisor/Makefile b/hypervisor/Makefile > > --- a/hypervisor/Makefile > > +++ b/hypervisor/Makefile > > @@ -30,6 +30,8 @@ > > KBUILD_CFLAGS += -include $(obj)/include/jailhouse/config.h > > endif > > > > +GCOV_PROFILE := n > > + > > CORE_OBJECTS = setup.o printk.o paging.o control.o lib.o mmio.o > > pci.o ivshmem.o > > define filechk_config_mk > > diff --git a/hypervisor/arch/arm-common/Kbuild > > b/hypervisor/arch/arm-common/Kbuild --- > > a/hypervisor/arch/arm-common/Kbuild +++ > > b/hypervisor/arch/arm-common/Kbuild @@ -17,3 +17,5 @@ > > OBJS-$(CONFIG_ARM_GIC_V2) += gic-v2.o > > > > COMMON_OBJECTS = $(addprefix ../arm-common/,$(OBJS-y)) > > + > > +GCOV_PROFILE := n > > Should better be placed before the objects - aplies to the following > hunks as well. > > > diff --git a/hypervisor/arch/x86/Kbuild b/hypervisor/arch/x86/Kbuild > > --- a/hypervisor/arch/x86/Kbuild > > +++ b/hypervisor/arch/x86/Kbuild > > @@ -22,3 +22,5 @@ > > > > built-in-amd-y := $(COMMON_OBJECTS) svm.o amd_iommu.o svm-vmexit.o > > cat-stubs.o built-in-intel-y := $(COMMON_OBJECTS) vmx.o vtd.o > > vmx-vmexit.o cat.o + > > +GCOV_PROFILE := n > > diff --git a/inmates/lib/arm-common/Makefile.lib > > b/inmates/lib/arm-common/Makefile.lib --- > > a/inmates/lib/arm-common/Makefile.lib +++ > > b/inmates/lib/arm-common/Makefile.lib @@ -16,3 +16,5 @@ > > OBJS-$(CONFIG_ARM_GIC_V2) += gic-v2.o > > > > COMMON_OBJECTS = $(addprefix ../arm-common/,$(OBJS-y)) > > + > > +GCOV_PROFILE := n > > diff --git a/inmates/lib/x86/Makefile.lib > > b/inmates/lib/x86/Makefile.lib --- a/inmates/lib/x86/Makefile.lib > > +++ b/inmates/lib/x86/Makefile.lib > > @@ -38,3 +38,5 @@ > > LDFLAGS_$(1)-linked.o := /dev/null -m elf_i386 -T > > $(1)_32 := y > > endef > > + > > +GCOV_PROFILE := n > > diff --git a/tools/Makefile b/tools/Makefile > > --- a/tools/Makefile > > +++ b/tools/Makefile > > @@ -20,6 +20,7 @@ > > -Wall -Wextra -Wmissing-declarations -Wmissing-prototypes > > -Werror \ -DJAILHOUSE_VERSION=\"$(shell cat $(src)/../VERSION)\" > > $(EXTRA_CFLAGS) LDFLAGS := > > +GCOV_PROFILE := n > > > > BINARIES := jailhouse > > HELPERS := \ > > > > Jan > -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
