On 2017-02-13 18:47, Ralf Ramsauer wrote:
> Commit dbd8656fa85f ("arm-common: Rework uart_chip wait callback to
> is_busy") makes those includes obsolete.
> 
> Signed-off-by: Ralf Ramsauer <[email protected]>
> ---
>  hypervisor/arch/arm-common/uart-8250.c    | 1 -
>  hypervisor/arch/arm-common/uart-pl011.c   | 1 -
>  hypervisor/arch/arm-common/uart-xuartps.c | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/hypervisor/arch/arm-common/uart-8250.c 
> b/hypervisor/arch/arm-common/uart-8250.c
> index e379dd27..8d24487f 100644
> --- a/hypervisor/arch/arm-common/uart-8250.c
> +++ b/hypervisor/arch/arm-common/uart-8250.c
> @@ -13,7 +13,6 @@
>   */
>  
>  #include <jailhouse/mmio.h>
> -#include <jailhouse/processor.h>
>  #include <asm/uart.h>
>  
>  #define UART_TX                      0x0
> diff --git a/hypervisor/arch/arm-common/uart-pl011.c 
> b/hypervisor/arch/arm-common/uart-pl011.c
> index ddb07bb2..1ae95deb 100644
> --- a/hypervisor/arch/arm-common/uart-pl011.c
> +++ b/hypervisor/arch/arm-common/uart-pl011.c
> @@ -11,7 +11,6 @@
>   */
>  
>  #include <jailhouse/mmio.h>
> -#include <asm/processor.h>
>  #include <asm/uart.h>
>  
>  #define UART_CLK     24000000
> diff --git a/hypervisor/arch/arm-common/uart-xuartps.c 
> b/hypervisor/arch/arm-common/uart-xuartps.c
> index 0daef9a0..4bb2b7c4 100644
> --- a/hypervisor/arch/arm-common/uart-xuartps.c
> +++ b/hypervisor/arch/arm-common/uart-xuartps.c
> @@ -11,7 +11,6 @@
>   */
>  
>  #include <jailhouse/mmio.h>
> -#include <jailhouse/processor.h>
>  #include <asm/uart.h>
>  
>  #define UART_SR                      0x2c
> 

Looks good, but a note on the tagging: "core:" should be used for
anything touching the generic hypervisor core, "<arch>:" for changes in
the arch-specific part of the hypervisor.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

-- 
You received this message because you are subscribed to the Google Groups 
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to