On 2017-04-03 13:59, Henning Schild wrote:
> The defines need values to work in C and they need to be "1" to
> generate config.mk. Update all examples to easy copy and paste
> and catch the quick reader.
> 
> Signed-off-by: Henning Schild <[email protected]>
> 
> diff --git a/Documentation/hypervisor-configuration.txt 
> b/Documentation/hypervisor-configuration.txt
> --- a/Documentation/hypervisor-configuration.txt
> +++ b/Documentation/hypervisor-configuration.txt
> @@ -5,59 +5,61 @@ Jailhouse supports various static compil
>  parameters, such as platform specific settings and debugging options.
>  Those settings can optionally be defined in
>  'hypervisor/include/jailhouse/config.h'.
> +Every configuration option should be defined to "1" or not be in the file at
> +all. Defining any other value can cause unexpected behaviour.
>  
>  Available configuration options
>  -------------------------------
>  
>  General configuration parameters
>  /* Print error sources with filename and line number to debug console */
> -#define CONFIG_TRACE_ERROR
> +#define CONFIG_TRACE_ERROR 1
>  /*
>   * Set instruction pointer to 0 if cell CPU has caused an access violation.
>   * Linux inmates will dump a stack trace in this case.
>   */
> -#define CONFIG_CRASH_CELL_ON_PANIC
> +#define CONFIG_CRASH_CELL_ON_PANIC 1
>  
>  ### Example board specific configurations
>  
>  #### ARM
>  
>  /* BananaPi M1 */
> -#define CONFIG_MACH_BANANAPI
> -#define CONFIG_ARM_GIC_V2
> +#define CONFIG_MACH_BANANAPI 1
> +#define CONFIG_ARM_GIC_V2 1
>  
>  /* Nvidia Jetson TK1 */
> -#define CONFIG_MACH_JETSON_TK1
> -#define CONFIG_ARM_GIC_V2
> +#define CONFIG_MACH_JETSON_TK1 1
> +#define CONFIG_ARM_GIC_V2 1
>  
>  /* Xunlong Orange Pi Zero, 256 MiB */
> -#define CONFIG_MACH_ORANGEPI0
> -#define CONFIG_ARM_GIC_V2
> +#define CONFIG_MACH_ORANGEPI0 1
> +#define CONFIG_ARM_GIC_V2 1
>  
>  /* ARM Fast Model */
> -#define CONFIG_MACH_VEXPRESS
> +#define CONFIG_MACH_VEXPRESS 1
>  /* Fast Model supports both, GICv2 and GICv3 */
> -#define CONFIG_ARM_GIC_V2
> +#define CONFIG_ARM_GIC_V2 1
>  /* #define CONFIG_ARM_GIC_V3 */
>  
>  #### ARM64
>  
>  /* Nvidia Jetson TK1 */
> -#define CONFIG_MACH_JETSON_TX1
> -#define CONFIG_ARM_GIC_V2
> +#define CONFIG_MACH_JETSON_TX1 1
> +#define CONFIG_ARM_GIC_V2 1
>  
>  /* Xilinx Zynq UltraScale+ MPSoC ZCU102 */
> -#define CONFIG_MACH_ZYNQMP_ZCU102
> -#define CONFIG_ARM_GIC_V2
> +#define CONFIG_MACH_ZYNQMP_ZCU102 1
> +#define CONFIG_ARM_GIC_V2 1
>  
>  /* HiKey LeMaker 2 GiB */
> -#define CONFIG_MACH_HIKEY
> -#define CONFIG_ARM_GIC_V2
> +#define CONFIG_MACH_HIKEY 1
> +#define CONFIG_ARM_GIC_V2 1
>  
>  /* ARMv8 Foundation Model */
> -#define CONFIG_MACH_FOUNDATION_V8
> -#define CONFIG_ARM_GIC_V2
> +#define CONFIG_MACH_FOUNDATION_V8 1
> +#define CONFIG_ARM_GIC_V2 1
>  
>  /* AMD ARM-Opteron A1100 */
> -#define CONFIG_MACH_AMD_SEATTLE
> -#define CONFIG_ARM_GIC_V2
> +#define CONFIG_MACH_AMD_SEATTLE 1
> +#define CONFIG_ARM_GIC_V2 1
> 

Looks good. Will merge right away as it's not directly related to gcov.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

-- 
You received this message because you are subscribed to the Google Groups 
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to