We cannot reliably tell apart errors that happen before we call into the hypervisor binary from those that happen after that. The latters may have left some relevant messages in the console buffer, but the former can make us dump confusing messages from a previous Jailhouse run.
Better let the user decide if the console content should be shown via an explicit invocation of "jailhouse console". Reported-and-suggested-by: Ralf Ramsauer <[email protected]> Signed-off-by: Jan Kiszka <[email protected]> --- tools/jailhouse.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/jailhouse.c b/tools/jailhouse.c index c23bb3bd..bc96b099 100644 --- a/tools/jailhouse.c +++ b/tools/jailhouse.c @@ -234,10 +234,8 @@ static int enable(int argc, char *argv[]) fd = open_dev(); err = ioctl(fd, JAILHOUSE_ENABLE, config); - if (err) { + if (err) perror("JAILHOUSE_ENABLE"); - dump_console(fd, true); - } close(fd); free(config); -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
