> +     case MSR_IA32_MISC_ENABLE:
> +             /* Allow 'Fast-Strings Enable' bit (pos. 0) changes, only */
> +             val = read_msr(MSR_IA32_MISC_ENABLE) & ~FAST_STRING_ENABLE;
> +             val |= get_wrmsr_value(&cpu_data->guest_regs) & 
> FAST_STRING_ENABLE;

> Overlong line now.

Fixed.

> +             /* Platform ID/Machine Info/Feature Control */
> +             [   0x10/8 ...   0x17/8 ] = 0x7f, /* 0x17-IA32_PLATFORM_ID */
> +             [   0x38/8 ...   0x3f/8 ] = 0xbf, /* 0x3a-IA32_FEATURE_CONTROL 
> */
> +             [   0xc8/8 ...   0xcf/8 ] = 0xbf, /* 0xce-MSR_PLATFORM_INFO */

> I would suggest to move the comments ahead of the initialization into a
> separate line to avoid >80 characters. Maybe also use the form "0x17:
> IA32_PLATFORM_ID" to avoid melting ID and symbol together.

Done.

> According to Andreas' finding, we seem to lack at least IA32_TSC_ADJUST.

Fixed. Let's hope these iterations for missing ones don't take long,
but I know it's a very probable thing :)

-- 
You received this message because you are subscribed to the Google Groups 
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to