On 2017-09-05 19:04, Ralf Ramsauer wrote: > On 09/05/2017 06:33 PM, Jan Kiszka wrote: >> On 2017-09-05 16:49, Ralf Ramsauer wrote: >>> This commit splits psci.h in two parts: register definitions and >>> hypervisor specific interface exports. >>> >>> psci_defs.h might be included by inmates as well, which is the reason >>> for the split up. This prevents that function might be referenced from >>> inmates, while their actual definition is mission. >> >> OK, so that psci_defs.h is what you'd like to share, right? All of it? > PSCI_CPU_ON_32, PSCI_CPU_ON_64, PSCI_CPU_OFF, PSCI_VERSION
Not that much... >> >> Besides I'm not a big fan of sharing with the hypervisor, you already >> mentioned the licensing topic. Creating your own defines seems the >> easiest way out, also from hypervisor POV. > Not that much. I'll introduce a new header for inmates. >> >> But good that you brought this up. I bet we have some more hidden >> sharing in the code that now has a licensing issue. Ugly. Let me check. > Yeah, I hit that during some collision while rebasing ;-) > > We're possibly sharing some sysreg definitions: > > lib/arm-common/include/inmate.h: arm_read_sysreg(MPIDR_EL1, mpidr); > lib/arm-common/timer.c: arm_read_sysreg(CNTFRQ_EL0, freq); > lib/arm-common/timer.c: arm_read_sysreg(CNTPCT_EL0, pct64); > lib/arm/gic-v3.c: arm_read_sysreg(ICC_IAR1_EL1, val); > lib/arm/header.S: arm_read_sysreg(MPIDR_EL1, r0) > > I think it was me that patched them in... > > As I need further sysreg definitions in my patches (MPIDR), best thing > is probably to duplicate them together with accessors as well. Thanks for finding this. That strengthens my proposal in the other thread to define what we really need in inmate-specific headers that are dual-licensed by the author. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
