On 2018-04-24 20:26, Alan Tull wrote: > On Tue, Apr 24, 2018 at 11:08 AM, Alan Tull <[email protected]> wrote: >> On Tue, Apr 24, 2018 at 12:29 AM, Jan Kiszka <[email protected]> wrote: >>> >>> We have drivers/fpga/of-fpga-region.c in-tree, and that does not seem to >>> store any pointers to objects, rather consumes them in-place. And I >>> would consider it fair to impose such a limitation on the notifier >>> interface. >> >> The FPGA code was written assuming that overlays could be removed. > > To be more specific, drivers/fpga/of-fpga-region.c currently saves a > pointer to the overlay and uses it only during the pre-apply > notification.
Even more exactly: You are saving a reference during pre-apply and freeing that one again on the corresponding post-remove. That is what I would have expected as normal usage of the notification API as well. Jan -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
