On 05/22/2018 04:27 PM, Jan Kiszka wrote: > On 2018-05-22 16:22, Ralf Ramsauer wrote: >> Hi, >> >> I'm missing one thing here: maintaining the linux loader for x86, as I >> don't understand this piece in jailhouse-cell-linux: >> >> class X86: >> [...] >> def params_address(self): >> return self._cpu_reset_address + 0x6000 >> >> Why is the params_address _cpu_reset_address + 0x6000 at the moment? I >> would expect + 0x100... > > These params are not the command line (the loader stub used none), it's > the Zero Page and related data for the kernel boot protocol. See also > ZERO_PAGE_ADDR = HEAP_BASE = hmmm... typically 0x6000. Looks like this > address dates back from a more stable memory layout on x86 (prio to > moving to reset address 0).
Ahh, okay. This is a bit confusing, as the semantics of params_address() for x86 are different from the other architectures. So everything should be fine -- including x86. Thanks Ralf > > Jan > >> >> Thanks >> Ralf >> >> On 05/22/2018 04:19 PM, Ralf Ramsauer wrote: >>> Now all architectures use the same address for the cmdline section to >>> ease the use of the cmdline. >>> >>> Signed-off-by: Ralf Ramsauer <[email protected]> >>> --- >>> Documentation/debug-output.md | 2 +- >>> inmates/lib/x86/inmate.lds | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/debug-output.md b/Documentation/debug-output.md >>> index fda38680..e0a7ff31 100644 >>> --- a/Documentation/debug-output.md >>> +++ b/Documentation/debug-output.md >>> @@ -146,7 +146,7 @@ Example command line parameters for PIO based debug >>> output on x86, where the >>> inmate will initialise UART: >>> >>> jailhouse cell load foocell inmate.bin \ >>> - -s "con-base=0x3f8 con-divider=1" -a 0x100 >>> + -s "con-base=0x3f8 con-divider=1" -a 0x1000 >>> >>> Example configuration for MMIO based debug output on ARM using the 8250 >>> driver: >>> >>> diff --git a/inmates/lib/x86/inmate.lds b/inmates/lib/x86/inmate.lds >>> index 526cf3b6..95c6ec97 100644 >>> --- a/inmates/lib/x86/inmate.lds >>> +++ b/inmates/lib/x86/inmate.lds >>> @@ -41,7 +41,7 @@ SECTIONS >>> . = 0; >>> .boot : { *(.boot) } >>> >>> - . = 0x100; >>> + . = 0x1000; >>> .cmdline : { >>> *(.cmdline) >>> BYTE(0); /* empty string in case no buffer is provided */ >>> > -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
