On 2018-05-24 14:32, Ralf Ramsauer wrote:
> 
> 
> On 05/24/2018 02:29 PM, Jan Kiszka wrote:
>> On 2018-05-24 14:24, Ralf Ramsauer wrote:
>>> Now there is only one user left of HEAP_BASE: The alloc() function its
>>> self. Fold the definition to mem.c.
>>>
>>> Signed-off-by: Ralf Ramsauer <[email protected]>
>>> ---
>>>  inmates/demos/x86/apic-demo.c | 2 +-
>>>  inmates/lib/x86/inmate.h      | 1 -
>>>  inmates/lib/x86/mem.c         | 2 +-
>>>  3 files changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/inmates/demos/x86/apic-demo.c b/inmates/demos/x86/apic-demo.c
>>> index 6657ca37..e62e22a3 100644
>>> --- a/inmates/demos/x86/apic-demo.c
>>> +++ b/inmates/demos/x86/apic-demo.c
>>> @@ -53,7 +53,7 @@ static void init_apic(void)
>>>  
>>>  static void pollute_cache(void)
>>>  {
>>> -   char *mem = (char *)HEAP_BASE;
>>> +   char *mem = alloc(PAGE_SIZE, PAGE_SIZE);
>>
>> Nice idea - but this is called in a loop...
> 
> Yikes, my bad! But that's fixable by passing the address to
> pollute_cache(mem).
> 
> I'd like to get rid of HEAP_BASE... Helps me later when generalising the
> allocator.
> 

Feel free to send some v2.

Jan

-- 
You received this message because you are subscribed to the Google Groups 
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to