On Saturday, 25 August 2018 02:35:05 UTC-4, Jan Kiszka wrote: > On 2018-08-25 03:02, christopher.goldsworthy wrote: > > On Tuesday, 21 August 2018 01:56:33 UTC-4, J. Kiszka wrote: > >> On 2018-08-20 21:41, Christopher Goldsworthy wrote: > >>> @@ -155,7 +162,7 @@ class Sysconfig: > >>> Sysconfig.PCIISVIRT_SIZE + > >>> Sysconfig.PCIDOMAIN_SIZE + > >>> Sysconfig.X86_PADDING) > >>> > >>> - keys = 'base size amd_bdf amd_base_cap amd_features' > >>> + keys = 'base_addr mmio_size amd_bdf amd_base_cap amd_features' > >> > >> This renaming of key base to base_addr seems like it could be handled > >> separately. Would shrink this patch. > > > > How so? I renamed it so it matches the attributes of IOMMUConfig in > > sysfs_parser.py, as that's the type of the object returned by parse_dmar() > > / parse_ivrs() that stores information on the IOMMUs. > > Aren't we free in choosing the property name before switching to the > sysfs_parser? > > Jan
Yes, but the whole point of this patch is that we use sysfs_parser. For clarity, I made the s/base/base_addr/ and s/size/mmio_size/ changes to accommodate both Sysconfig (whose keys are 'base' and 'size') and IOMMUConfig (whose attributes are 'base_addr' and 'mmio_size'). If I'd have to change one to accommodate both. Perhaps I'm misunderstanding what you're saying. Regardless, I'll remove Sysconfig anyway, since you said you see no need for doing offline checks. Chris. -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
