Hello Mr. Kiszka,

The patch fixed all the problems. Thank you for your help.

Best regards,
Burak Atalay

-----Original Message-----
From: Jan Kiszka <[email protected]> 
Sent: Thursday, January 24, 2019 9:44 AM
To: Jailhouse <[email protected]>
Cc: Atalay Burak 1CS2 <[email protected]>; Haase Heiko 1CS2 
<[email protected]>
Subject: *EXT* [PATCH] pyjailhouse: sysfs_parser: Fix msix_address calculation

A missing brace caused 64-bit addresses to be truncated to 32-bit.

Signed-off-by: Jan Kiszka <[email protected]>
---

After applying your patch and regenerating your config, Burak, your VT-d faults 
should be resolved.

 pyjailhouse/sysfs_parser.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pyjailhouse/sysfs_parser.py b/pyjailhouse/sysfs_parser.py index 
e050af47..4dec6df7 100644
--- a/pyjailhouse/sysfs_parser.py
+++ b/pyjailhouse/sysfs_parser.py
@@ -611,7 +611,8 @@ class PCICapability:
                     raise RuntimeError('Invalid MSI-X BAR found')
                 if (bar & 0x4) != 0:
                     bar |= struct.unpack('<I', f.read(4))[0] << 32
-                msix_address = (bar & 0xfffffffffffffff0) + table & 0xfffffff8
+                msix_address = \
+                    (bar & 0xfffffffffffffff0) + (table & 0xfffffff8)
                 flags = PCICapability.RW
             else:
                 # unknown/unhandled cap, mark its existence
--
2.16.4

-- 
You received this message because you are subscribed to the Google Groups 
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to