On 26.07.19 02:02, Ralf Ramsauer wrote: > On 7/25/19 7:11 PM, Ralf Ramsauer wrote: >> Obvious what happens here: Align the root cell template. >> >> Signed-off-by: Ralf Ramsauer <[email protected]> >> --- >> tools/jailhouse-cell-linux | 2 +- >> tools/root-cell-config.c.tmpl | 22 +++++++++------------- >> 2 files changed, 10 insertions(+), 14 deletions(-) > > I forgot one thing in the config generator: > s/pio_bitmap_size/num_pio_regions/ > > But it doesn't break anything, as this variable is not used.
You likely mean tools/jailhouse-cell-linux, not tools/jailhouse-config-create. > > And another finding: > $ git grep pio_bitmap_size > configs/arm64/amd-seattle-gic-demo.c: .pio_bitmap_size = 0, > configs/arm64/amd-seattle-uart-demo.c: .pio_bitmap_size = 0, > [...] > > Those are futile in two regards: ARM64 doesn't have x86 I/O ports, and > they're set to zero anyway. I'll write a patch for that. You mean a removal of all those zero-initializations for configs/arm64? Would be good. Needs to come before patch 3. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jailhouse-dev/67c28269-d9fd-f084-fdf6-c991b73f0e9f%40siemens.com.
