[...]

On 1/6/20 1:18 PM, Jan Kiszka wrote:
> diff --git a/include/jailhouse/cell-config.h b/include/jailhouse/cell-config.h
> index a62fa1ee..f82bbe8d 100644
> --- a/include/jailhouse/cell-config.h
> +++ b/include/jailhouse/cell-config.h
> @@ -129,6 +129,15 @@ struct jailhouse_memory {
>       __u64 flags;
>  } __attribute__((packed));
>  
> +#define JAILHOUSE_SHMEM_NET_REGIONS(start, dev_id)                   \
> +     {                                                               \
> +             .phys_start = start,                                    \
> +             .virt_start = start,                                    \
> +             .size = 0x100000,                                       \
> +             .flags = JAILHOUSE_MEM_READ | JAILHOUSE_MEM_WRITE |     \
> +                     JAILHOUSE_MEM_ROOTSHARED,                       \
> +     }
> +

In the end of the series, this makes calculation of .num_memory_region
unintuitive: the macro will eventually roll out to four memory regions.
Would it make sense to introduce a macro that denotes the number of
regions that are created by JAILHOUSE_SHMEM_NET_REGIONS?

  Ralf

-- 
You received this message because you are subscribed to the Google Groups 
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jailhouse-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jailhouse-dev/02d5b3ac-54d6-48bc-5eed-eb0a91186647%40oth-regensburg.de.

Reply via email to