On 12.08.20 15:32, Peng Fan wrote:
Subject: Re: [PATCH V1 4/5] arm: include: protect header file
hypervisor/arch/arm/include/asm/bitops.h
On 11.08.20 20:16, Alice Guo wrote:
Use "__ARM32_ASM_BITOPS__" to avoid redefine functions declared in
hypervisor/arch/arm/include/asm/bitops.h when building for AArch32.
I do not yet understand the exact need.
I think we should add some guard to make sure the contents in a header file
could only be included once. Otherwise it would be easy
to trigger issues if files was included twice by some nested including.
We do this on a need-to-have basis in Jailhouse. In this case, there is
clearly no need because of the inclusion policy of this header (only via
the generic one).
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
--
You received this message because you are subscribed to the Google Groups
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jailhouse-dev/b1c22f4e-e712-a1df-7835-ae7c4cea747d%40siemens.com.
