On 21/10/2020 20:44, Jan Kiszka wrote: > On 21.10.20 20:43, Jan Kiszka wrote: >> On 21.10.20 16:53, Andrea Bastoni wrote: >>> Signed-off-by: Andrea Bastoni <[email protected]> >>> --- >>> hypervisor/Makefile | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/hypervisor/Makefile b/hypervisor/Makefile >>> index 5322b5aa..41bf99f3 100644 >>> --- a/hypervisor/Makefile >>> +++ b/hypervisor/Makefile >>> @@ -31,6 +31,10 @@ KBUILD_CFLAGS := -g -Os -Werror -Wall -Wstrict-prototypes >>> -Wtype-limits \ >>> -fno-strict-aliasing -fno-pic -fno-common \ >>> -fno-stack-protector -fno-builtin-ffsl \ >>> -D__LINUX_COMPILER_TYPES_H >>> +# Nice to have: -Wcast-qual -Wpointer-arith >> >> Shouldn't got here as comment. >> >>> +KBUILD_CFLAGS += -Wextra -Wundef \ >>> + -Wnested-externs -Wshadow -Wredundant-decls \ >>> + -Wdeprecated >> >> Should be merged into the assignment above, no need for splitting it up. >> >> However, this must come last as we have -Werror, and you are now breaking the >> build.
Yes. I thought too late that the order should be reverted for next. >> > > It could also come in pieces > > 1. fix nested-externs > 2. enable related warning > 3. fix shadow > 4. enable related warning > ... Yes. But Werror should be added last then. -- Thanks, Andrea Bastoni -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jailhouse-dev/fd0aecbc-2650-7df2-f113-eae7ec85da7e%40tum.de.
