On 27/10/2020 14:29, Jan Kiszka wrote: > On 22.10.20 19:58, Andrea Bastoni wrote: >> The cast is just to prevent fallouts due to the Werror. The error and >> rax are really unsigned values, but int to unsigned promotion is mixed >> too many times to be easily fixed. >> >> Signed-off-by: Andrea Bastoni <[email protected]> >> --- >> hypervisor/arch/x86/control.c | 2 +- >> hypervisor/arch/x86/vcpu.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/hypervisor/arch/x86/control.c b/hypervisor/arch/x86/control.c >> index 2aea807a..98659f4a 100644 >> --- a/hypervisor/arch/x86/control.c >> +++ b/hypervisor/arch/x86/control.c >> @@ -238,7 +238,7 @@ x86_exception_handler(struct exception_frame *frame) >> { >> panic_printk("FATAL: Jailhouse triggered exception #%lld\n", >> frame->vector); >> - if (frame->error != -1) >> + if ((int)frame->error != -1) > > Why not define and use some EXCEPTION_NO_ERROR as ~(0) here as well?
I didn't want to introduce extra includes in arch/x86/entry.S (or have different values in control.c compared to entry.S). But yes, EXCEPTION_NO_ERROR can be added. -- Thanks, Andrea Bastoni -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jailhouse-dev/a55ec69c-fcc0-00e8-b427-ce19292a4946%40tum.de.
