On 07.02.21 14:04, Andrea Bastoni wrote: > > > On 07/02/2021 11:18, Jan Kiszka wrote: >> On 25.01.21 13:00, Andrea Bastoni wrote: >>> Signed-off-by: Andrea Bastoni <[email protected]> >>> --- >>> hypervisor/include/jailhouse/control.h | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/hypervisor/include/jailhouse/control.h >>> b/hypervisor/include/jailhouse/control.h >>> index 76eb0428..2ac7e2dd 100644 >>> --- a/hypervisor/include/jailhouse/control.h >>> +++ b/hypervisor/include/jailhouse/control.h >>> @@ -9,6 +9,8 @@ >>> * This work is licensed under the terms of the GNU GPL, version 2. See >>> * the COPYING file in the top-level directory. >>> */ >>> +#ifndef _JAILHOUSE_CONTROL_H >>> +#define _JAILHOUSE_CONTROL_H >>> >>> #include <jailhouse/bitops.h> >>> #include <jailhouse/percpu.h> >>> @@ -298,3 +300,5 @@ void __attribute__((noreturn)) arch_panic_stop(void); >>> void arch_panic_park(void); >>> >>> /** @} */ >>> + >>> +#endif >>> >> >> I think we could also consider #pragma once, with the same rationals as >> in [1]. > > Yes, and no. It depends if you are aiming to some e.g., MISRA-compliancy > and/or > if you don't have to document the implementation-defined behavior of pragma. >
Might be a point (not MISRA but non-standard). Then defer this for now. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jailhouse-dev/37da2db9-cd0b-5729-c948-ab074f186b28%40siemens.com.
